Forum Links 

Click to return to main page
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile  Log in to check your private messagesLog in to check your private messages    Log inLog in 
 Current Top Rated Killers 
 Next Event   Voting Links 


The event "The Assault on Taekir" is beginning in 1 day, 5 hours.

Groups disbanding

 
Post new topic   Reply to topic    Abandoned Realms Forum Index -> The Battlefield
View previous topic :: View next topic  
Author Message
Olyn
Immortal


Joined: 23 Jul 2008
Posts: 3244
Location: Pennsylvania

PostPosted: Sun Apr 07, 2019 10:08 pm    Post subject: Groups disbanding

We've had reports for some time now about groups occasionally disbanding when certain charmed mobs leave. I took a stab at fixing a potential cause today. Let us know on here if your group still disbands at any time when it shouldn't or if anything else group-related became inadvertently worse.
Back to top
View user's profile Send private message
 
1 0 0
Olyn
Immortal


Joined: 23 Jul 2008
Posts: 3244
Location: Pennsylvania

PostPosted: Tue Apr 09, 2019 6:13 pm    Post subject:

Are there any rangers or illusionists able to test weird group disbands and pets attacking owners? Those two classes seemed to generate the most reports prior to the fix.
Back to top
View user's profile Send private message
 
0 0 0
Nycticora



Joined: 09 Feb 2013
Posts: 2277

PostPosted: Wed Apr 10, 2019 8:26 am    Post subject:

there was a specific change that I remember making a long time ago that might have broken this, I'll try to remember what it was. There was a group + reaper bug and I drastically changed the way groups work and I remember both dav and I were surprised when it worked

I think it was when we added the necro skeleton and let pets group, there might be something wrong with groups that have a leader with a pet who isn't in the group, or maybe issues where a pet is erroneously marked as the group leader when someone leaves or dies

I remember being confused at the difference between leader and master and what happened when one was enabled but not the other
Back to top
View user's profile Send private message
 
0 0 0
Nycticora



Joined: 09 Feb 2013
Posts: 2277

PostPosted: Wed Apr 10, 2019 8:33 am    Post subject:

f326a7e782b55406670019df23a338a96f6572f9 was the original commit that added this logic, might be able to compare that CL to current state to see what's up

this system has seen lots of work, it looks way improved now compared to how it was in 2017

it looks like the most likely way to break a group should be when you add a mob following one of your groupmembers to the group, and then that mob either dies or leaves due to the parent leaving (logging out?). Or maybe a duplicate disappearing.

Issue 4 is probably less relevant to current state than issue 215, issue 4 is too old.
Back to top
View user's profile Send private message
 
0 0 0
Display posts from previous:   
Post new topic   Reply to topic    Abandoned Realms Forum Index -> The Battlefield All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © phpBB Group